fix resize! for LowStorageRK2NCache; closes #1277 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's hitting a fallback: https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/alg_utils.jl#L5-L29 |
|
Well, I'm sure we had OrdinaryDiffEq.jl/src/alg_utils.jl Line 17 in 821fc83 Anyway, we still need an additional check of u_modified to update tmp for 2N methods, which is implemented here.
|
|
I think @kanav99 did something with that due to Williamson condition and ensuring low storage? I'll merge and we can discuss this more. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1277 for
DiscreteCallbacks. I had to re-eval the FSAL part, since the 2N methods are not recognized as FSAL methods although they evaluate the RHS for the new step. Why?